search

dhowe / ChinaEye

Experience the web as if you were living in China...
Artistic License 2.0
9 stars 3 forks source link

Make clear that a search is blocked in Info-mode #54

Closed dhowe closed 7 years ago

dhowe commented 7 years ago

In the result below, the search term is blocked, but there is no indication in the menu (only the icon which is hard to understand). If this is a quick fix, then lets add it to v1.0. If not, then you can push it to v1.1 (mark with 'next-tasks' milestone)

screen shot 2017-03-27 at 12 36 52 pm

cqx931 commented 7 years ago

What you described doesn't seem to be only applied to info mode, it is showing the blocked keyword in popup window. It should be a quick fix, but more of a design issue. How about something like this: image

cqx931 commented 7 years ago

Option 2 image

cqx931 commented 7 years ago

or it should be "The above keyword is blocked within mainland China"?

dhowe commented 7 years ago

Good -- I like option 2. And yes, it should be "Your search keyword is blocked in mainland China!"

cqx931 commented 7 years ago

https://github.com/dhowe/ChinaEye/commit/58b8e8a2a6699f7b79309d45c77500c147c6be5a