search

dhowe / ChinaEye

Experience the web as if you were living in China...
Artistic License 2.0
9 stars 3 forks source link

Question on 'disable' for search engines #73

Closed dhowe closed 6 years ago

dhowe commented 6 years ago

Are we disabling for the site or for the search query?

cqx931 commented 6 years ago

Do you see a "disable" button? There should always be a "Disable for this site" button and also a "Disable for this search" button for search engines if the current search is triggering a block.

dhowe commented 6 years ago

So I think what is happening is that b/c the search engine itself is blocked, one never sees the 'disable for this search' button, even if the search itself would be blocked as well.

And then once 'disabled for the site' is clicked, it is disabled for all search queries as well...

So there is no way, currently, to say disable for the site, unless the search is blocked...

Is all this correct?

cqx931 commented 6 years ago

You can only see "disable for this search" button if the search query is a match with our list. But this button is not visible, for example, if you search "credit card" on google, because the search itself can't trigger a block. image

dhowe commented 6 years ago

Right, but for the case where BOTH the site and query are blocked, one sees only the 'disable for this site' button (same search as yours below)

image

cqx931 commented 6 years ago

Can you provide your search link? I can still see "disable for this search" if I change my search engine to google.com.hk

dhowe commented 6 years ago

So your query is being blocked, but the site is showing as blocked for me...

https://www.google.com.hk/search?ei=FvwNWry3MIKy0ATn-6DoBg&q=grass+mud+horse+&oq=grass+mud+horse

cqx931 commented 6 years ago

For the link above, the issue seems be caused by the extra "+" before "oq=grass+mud+horse" Please check the fix here: https://github.com/dhowe/ChinaEye/pull/74