search

dhowe / ReadersJS

1 stars 4 forks source link

Update website to point to readers-js-live #113

Closed dhowe closed 7 years ago

dhowe commented 7 years ago

LOCATIONS (others?):

http://thereadersproject.org/elc3.html#ELC3 http://thereadersproject.org/index.html (add link to left nav?)

shadoof commented 7 years ago

amended the elc3.html and pushed on the master branch. Make silent edits and then make live (if it isn't live automatically). I'll do more edits on my own branch (of ReadersWeb) and then submit pull requests in the future?

dhowe commented 7 years ago

this way is fine, as long as you tell me when to push live (or you can do it)

shadoof commented 7 years ago

Better, in terms of workflow, if you check and make live. I've just pushed a sidebar link as requested and if you are happy with these changes, you can make live and then close this.

shadoof commented 7 years ago

I suggest making a new live version of the Readers and then also making the link changes to the website that I've made live also. And close this unless there's more you need at the moment.

dhowe commented 7 years ago

should both be live

shadoof commented 7 years ago

@dhowe I'm not seeing the version of the site with sidebar link and elc3 page referencing the 'Live' sight. Should I reopen? (Opportunity here to disseminate the site to a brunch of relatively cool DH peeps)

shadoof commented 7 years ago

Argh, pull request on its way ...

shadoof commented 7 years ago

actually just pushed to master

dhowe commented 7 years ago

Note that an a merged PR (or a direct push to master) does NOT make changes like on the site. This also requires a git pull from the directory on rednoise

shadoof commented 7 years ago

Understood, @dhowe. Unless you want me too, when I make changes to the website I will push to master, but leave you to pull the site on rednoise and make it live (after checking/amending).