dhowe / ReadersJS

1 stars 4 forks source link

Remaining interface issues #145

Closed dhowe closed 7 years ago

dhowe commented 7 years ago
untitled
  1. Fix vertical alignment above
  2. Clicking on any part of another reader (either their circles, names, or F/S/speed buttons) should disable the solo on another reader
  3. Try lighter font for all buttons
  4. Add hover instructions for all buttons
cqx931 commented 7 years ago

4.What do you mean by 'all buttons'? Only S/F are actually buttons.... or you mean buttons and selects?

dhowe commented 7 years ago

yes, buttons and selects

cqx931 commented 7 years ago

Please let me know if I still miss any alignment here: Tried lighter font for all selects, also smaller font for selects/buttons for each reader image

image

dhowe commented 7 years ago

Looks much better! Can we also try the same text treatment for the Text/Style/Theme options at bottom, just as an experiment?

Also, we need a hover for the colored circles as well (enable/disable)

Also, the alignment is still not quite correct for Text/Style/Theme pulldowns

cqx931 commented 7 years ago

Colored circles are a bit different than other elements as it is made using pseudo element (:after) in css. I need to rearrange the dom structure a little bit to achieve this. One thing I want to double check before working on this is: Currently both clicking on the circle and the text can enable/disable readers. Is this correct or we want enable/disable function only for the circle and not for the text?

cqx931 commented 7 years ago

A preview for the select style: I guess you mean just the text style but not the size here image

dhowe commented 7 years ago

That seems better -- can we try without capital letters? Text, Style, Theme?

dhowe commented 7 years ago

Currently both clicking on the circle and the text can enable/disable readers. Is this correct or we want enable/disable function only for the circle and not for the text?

I think only the circle...

cqx931 commented 7 years ago

image

dhowe commented 7 years ago

this looks better to me

cqx931 commented 7 years ago

Please check https://github.com/dhowe/ReadersJS/pull/147

cqx931 commented 7 years ago

Can this be closed?