Closed dhowe closed 7 years ago
4.What do you mean by 'all buttons'? Only S/F are actually buttons.... or you mean buttons and selects?
yes, buttons and selects
Please let me know if I still miss any alignment here: Tried lighter font for all selects, also smaller font for selects/buttons for each reader
Looks much better! Can we also try the same text treatment for the Text/Style/Theme options at bottom, just as an experiment?
Also, we need a hover for the colored circles as well (enable/disable)
Also, the alignment is still not quite correct for Text/Style/Theme pulldowns
Colored circles are a bit different than other elements as it is made using pseudo element (:after) in css. I need to rearrange the dom structure a little bit to achieve this. One thing I want to double check before working on this is: Currently both clicking on the circle and the text can enable/disable readers. Is this correct or we want enable/disable function only for the circle and not for the text?
A preview for the select style: I guess you mean just the text style but not the size here
That seems better -- can we try without capital letters? Text, Style, Theme?
Currently both clicking on the circle and the text can enable/disable readers. Is this correct or we want enable/disable function only for the circle and not for the text?
I think only the circle...
this looks better to me
Please check https://github.com/dhowe/ReadersJS/pull/147
Can this be closed?