Uncaught error after solo'ing a reader then changing texts, then un-solo'ing

dhowe / ReadersJS

1 stars 4 forks source link

Uncaught error after solo'ing a reader then changing texts, then un-solo'ing #152

Closed shadoof closed 7 years ago

shadoof commented 7 years ago

Uncaught Error: Grid.gridFor(): no grid for RiText: [498,40,'a'] at Function.Grid.gridFor (readers-app.js:781) at SpawningSimpleReader.onEnterCell (spawning-simple-reader.js:47) at SpawningSimpleReader.step (readers-app.js:1118) at readers-app.js:1123

... will, I think also be caused by any reader turned off when text is changed.

To reproduce:

launch app
solo a reader
change text (e.g. from misspelt to poetic)
un'solo

dhowe commented 7 years ago

@shadoof does this break anything or is it just a spurious error message?

Notice also that this error is NOT for the solo'd reader, but for some other reader

dhowe commented 7 years ago

@shadoof please check and close if ok

shadoof commented 7 years ago

Seems good to me 👍