search

dhowe / RiTaV1

RiTa: the generative language toolkit
http://rednoise.org/rita
GNU General Public License v3.0
354 stars 78 forks source link

Problem with words starting with vowel phones in alliterations() #293

Closed dhowe closed 7 years ago

dhowe commented 8 years ago

See RiTa: rita.test.KnownIssuesTest.java::testAlliterations

cqx931 commented 7 years ago

This was the first fix to this ticket https://github.com/dhowe/RiTa/commit/b3881b59a0621cb4f5c139b4f10c2049a5aaea04

But new issues emerged when I tried to fix the issue. Currently, the alliteration function always check the firstStressedSyllable, so it will regard "withdraw" as an alliteration for "dog" (draw - dog) Please see corresponding test-cases and comments here: https://github.com/dhowe/RiTa/pull/378

So instead of the the firstStressedSyllable, the first phoneme should be check in oder to get this fixed.

dhowe commented 7 years ago

so we are not counting assonance, in this algorithm, is that correct?

    ok(!lex.isAlliteration("octopus", "oblong"));
    ok(!lex.isAlliteration("omen", "open"));
    ok(!lex.isAlliteration("amicable", "atmosphere"));
cqx931 commented 7 years ago

Yes, I think so. And we will return null if the user try to get assonance with words starting in vowels, correct?