dhruv8sh / arch-update-checker

Plasma 6 applet to check for AUR and Arch updates
GNU General Public License v2.0
70 stars 5 forks source link

[Bug] Horizontal scrollbar #30

Closed Kingproone closed 3 months ago

Kingproone commented 3 months ago

I just wanna ask, why is there a horizontal scrollbar sometimes at the bottom of the widget, like in this picture from the readme: https://private-user-images.githubusercontent.com/67322047/319741581-c5d726d4-a769-4dba-918b-06e921650e5e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI1MTU2MDYsIm5iZiI6MTcxMjUxNTMwNiwicGF0aCI6Ii82NzMyMjA0Ny8zMTk3NDE1ODEtYzVkNzI2ZDQtYTc2OS00ZGJhLTkxOGItMDZlOTIxNjUwZTVlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDA3VDE4NDE0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThhMzRlMzQ2NjYzZWY5OTFiZDUyOTIyMzJmNGUyY2EzOTE4NjVjZjJkYWM0ZmUwYzkxZWE4Y2ZkNTRiOGNiZjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.91WXvYeq_dyYQZEQ8nMJYH8b86hWgTJ_WvcDlq3oBuU

Kingproone commented 3 months ago

since the above link broke: image

dhruv8sh commented 3 months ago

Yes this was reproducible. Turns out when the ScrollView tries to draw a Vertical Scrollbar it miscalculates margins by 1px. Hence, the horizontal scrollbar. Next release is today. It will be fixed in that.

dhruv8sh commented 3 months ago

Fixed!

Kingproone commented 1 month ago

I can consistently trigger it in 0.9.10 (it appears regardless of how wide I make the widget):

Screencast_20240523_131717.webm

also, at the bottom what is (NaN undefined)?

dhruv8sh commented 1 month ago

The horizontal scrollbar does not exist for me... image

It is supposed to show the download size for update. No idea why it's bugging out for you. image

dhruv8sh commented 1 month ago

I'll make the download size so that it does not show up when it's NaN, undefined or whatever.

Kingproone commented 1 month ago

It probably bugged, because I only had AUR updates.

dhruv8sh commented 1 month ago

That should not matter, since all the information is fetched from 'pacinfo'.

Kingproone commented 1 month ago

The horizontal scrollbar does not exist for me...

It may be, because when I changed the pause unpause, the vertical scrollbar appeared and that update trips it up somehow

That should not matter, since all the information is fetched from pacinfo.

weird

dhruv8sh commented 1 month ago

Can you test the latest commit for the scrollbar fix?

Kingproone commented 1 month ago

Screencast_20240523_135056.webm

dhruv8sh commented 1 month ago

Did you run systemctl --user restart plasma-plasmashell after updating?

Kingproone commented 1 month ago

Screencast_20240523_135427.webm

it doesn't trigger no more (after the restart), but at the buttom says 0 (right after the text), when only aur is left