search

dhruv8sh / arch-update-checker

Plasma 6 applet to check for AUR and Arch updates
GNU General Public License v2.0
71 stars 5 forks source link

FIX: Update not searching afterwards #58

Closed phddoom closed 3 months ago

phddoom commented 3 months ago

Due to action_updateSystem() calling searching(), isUpdating gets set globally. At the end of action_updateSystem() execInTerminal() is used to perform the actual update.

execInTerminal() if passed true as it's last argument will call action_searchForUpdates() which will early return if isUpdating is already set to true.

Thus to make the search intended by the searchAfter argument of execInTerminal() happen stopSearch() needs to be called before calling action_searchForUpdates().

dhruv8sh commented 3 months ago

There is a complete cleanup coming up. It should be up in a couple hours. I just need to test a few things. It refactors the mentioned files and more in a major way. Hence, unfortunately, it would not be merged. Although, I really appreciate the effort and I hope you contribute more to the project. Edit: The new refactors have been merged. Please test the widget out if you can.