search

dhruv8sh / arch-update-checker

Plasma 6 applet to check for AUR and Arch updates
GNU General Public License v2.0
70 stars 5 forks source link

[Bug] Regressions in 0.10 #59

Closed Kingproone closed 2 days ago

Kingproone commented 6 days ago
  1. missing fallback icon for the download button

Screenshot_20240702_212626

  1. no floating description for the resfresh and download buttons (the package ordering button has it)

  2. when the widget is placed in the taskbar or on the desktop has no minimum size which allows for the following:

Screenshot_20240702_213444 Screenshot_20240702_213514

dhruv8sh commented 6 days ago

Good points about tooltip and minimum size. The first issue has to do with your icon theme. Nothing I can do about it.

Just putting this here so I remember: Fix notifications. Add logging back Remove "show intro" from config Change pictures in the README

Kingproone commented 6 days ago

2.5. the pause button (moved to the buttom right) is also missing a floating message

  1. when clicking the pause button it does not change the icon to a play button (was it like this before 0.10? i was not using that button)
dhruv8sh commented 6 days ago

The pause icon follows the HIG by KDE Plasma.

Kingproone commented 6 days ago

can I ask what point you're referring to? it's quite a few pages

dhruv8sh commented 5 days ago

I'll have to look through it, but it says something like - Only change icons for state-changing buttons(such as the sort button), if it is check-able don't bother changing because it's checked is indicative of the state.

dhruv8sh commented 2 days ago

Please pull and check the latest commits.

Kingproone commented 2 days ago

v 10.5

  1. , 2.5 and 3. fixed. 4: I still feel should change between the play and the pause icon (kde' in house mpv video player: haruna does so as well)

the taskbar and desktop minimum size work, however the desktop version becomes a clickable button that opens the widget which looks quite funny Screenshot_20240707_113928

Kingproone commented 2 days ago

As a side note, if you press shift + print screen plasma will capture the current focused window so you dont have to go and crop them leaving in the 1 pixel wallpaper borders (currently the readme features these). Just turn off the option to capture window shadows.

Kingproone commented 2 days ago

I can also see that pamac support was deprecated. (I'm no manjaro fan, so I'll live) But since it is a regression I thought it was worth a mention.

dhruv8sh commented 2 days ago

I still feel should change between the play and the pause icon

The checkable state of the button would make it confusing, I will go forward with the current method.

the taskbar and desktop minimum size work, however the desktop version becomes a clickable button that opens the widget which looks quite funny

Fixed!

pamac support was deprecated

Add info about this to the README Changed the image with the visible wallpaper in the README