dhruvabhat24 / weather-app

It is a weather app made using react.js
https://weather-app-lac-pi.vercel.app
MIT License
17 stars 21 forks source link

Rather than using DOM to access elements, separate components should be created. #18

Open rajneesh069 opened 9 months ago

rajneesh069 commented 9 months ago

Since we are using React.js as our front-end framework hence we should create different components for different UI elements rather than using DOM to access/manipulate them as it makes things confusing as it depicts that those elements are in the static index.html file but in reality they are just being returned inside the main WeatherApp function inside "WeatherApp.jsx". I am attaching relevant screenshots here. Please look into it.

rajneesh069 commented 9 months ago

Screenshot from 2023-12-31 19-47-28

TejasSathe010 commented 9 months ago

I can fix this issue if not yet fixed or assigned to anyone. Thank you!

dhruvabhat24 commented 9 months ago

@rajneesh069 I have assigned it to you.

rajneesh069 commented 9 months ago

@rajneesh069 I have assigned it to you.

Okay, I'll work on it. Although I'll need some time to work on it as I am occupied with my own project right now.

dhruvabhat24 commented 9 months ago

Okay take your time

Ceejay-777 commented 9 months ago

Hi. The useref() hook is used to access elements right? In my opinion, it would be a great idea to employ that.

Ceejay-777 commented 9 months ago

Hi, good day. Can I work on this? I should be done with it soon.

dhruvabhat24 commented 9 months ago

Okay I will assign it to you

DeeKoders commented 4 months ago

If this issue is still open, i'll work on it. Please assign it to me if still available.

dhruvabhat24 commented 4 months ago

@DeeKoders Sorry for the delay this task is assigned to you and you can work on it

DeeKoders commented 4 months ago

@DeeKoders Sorry for the delay this task is assigned to you and you can work on it

on it

DeeKoders commented 4 months ago

@dhruvabhat24 The issue seems to be resolved. Can you verify it and close the issue

dhruvabhat24 commented 4 months ago

Okay Let me check