search

dhruvabhat24 / weather-app

It is a weather app made using react.js
https://weather-app-lac-pi.vercel.app
MIT License
17 stars 21 forks source link

Issue #12 - Handle fetching error at current location fetching #23

Closed ThomasLagace closed 9 months ago

ThomasLagace commented 9 months ago

Fixes error handling from issue #12.

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
weather-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2024 1:45pm
dhruvabhat24 commented 9 months ago

@ThomasLagace Getting some issues I have attached a vedio below Check it and resolve the issue

https://github.com/dhruvabhat24/weather-app/assets/122305929/311d11ed-23dc-4de9-899e-bf98321e337c

ThomasLagace commented 9 months ago

Ho! I will fix it as soon as possible.

gitguardian[bot] commented 9 months ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | OpenWeatherMap Token | 3dceeaf11ba8455744d922dad2b80e21fc371a87 | src/components/WeatherApp/WeatherApp.jsx | [View secret](https://github.com/dhruvabhat24/weather-app/commit/3dceeaf11ba8455744d922dad2b80e21fc371a87#diff-7ba96fb437378d6fc9b53a1e6b22cf29R14) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/specifics/open_weather_map#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

dhruvabhat24 commented 9 months ago

Nice one I have merged it