dhruvabhat24 / weather-app

It is a weather app made using react.js
https://weather-app-lac-pi.vercel.app
MIT License
17 stars 21 forks source link

Adding Forecast Feature & enabling anyone to generate report PDFs fixes#13 #37

Closed saksham-jain177 closed 8 months ago

saksham-jain177 commented 8 months ago

fixes #13

I did the tasks to include Fetching weather data and enabling user to download report afterwards

But, the data fetched is unfortunately not Historical data (Past data) but Forecast As, historical data requires heavy pricing of the API services

https://github.com/dhruvabhat24/weather-app/assets/73608200/66739d8c-69ad-4d18-a114-8e9c9a91a4be

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
weather-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2024 8:30pm
gitguardian[bot] commented 8 months ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | | Generic High Entropy Secret | 546e7469c16a3a2aad6809ccd5aac073e9a4392c | .env | [View secret](https://github.com/dhruvabhat24/weather-app/commit/546e7469c16a3a2aad6809ccd5aac073e9a4392c#diff-e9cbb0224c4a3d23a6019ba557e0cd568c1ad5e1582ff1e335fb7d99b7a1055dR1) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | | Generic High Entropy Secret | 546e7469c16a3a2aad6809ccd5aac073e9a4392c | .env | [View secret](https://github.com/dhruvabhat24/weather-app/commit/546e7469c16a3a2aad6809ccd5aac073e9a4392c#diff-e9cbb0224c4a3d23a6019ba557e0cd568c1ad5e1582ff1e335fb7d99b7a1055dL2) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

dhruvabhat24 commented 8 months ago

Nice Work Thanks for contributing