search

dhruvbansal / rubix

A Ruby client for configuring and writing to Zabbix
Other
25 stars 12 forks source link

SSL Connection Support, Host IPMI Attribute Support, 2 bug fixes #4

Closed unilogic closed 12 years ago

unilogic commented 12 years ago

See commit descriptions for changes.

Thanks,

Ben

dhruvbansal commented 12 years ago

You're epic! Looking into it now.

dhruvbansal commented 12 years ago

Thanks for the commit! I think I'm using an older version of Zabbix server than you are (I'm on 1.8.8). I had to make a couple little tweaks to get the tests to pass on my end, nothing major though.

One meaningful change I did make was to set the default value of use_ipmi in hosts to 'false' -- this matches my Zabbix 1.8.8 server's default.

Thanks again for the work!

unilogic commented 12 years ago

Thanks for merging! Default on use_ipmi makes sense to be false.