search

dhruvmanila / browser-bookmarks.nvim

A Neovim plugin to open your browser bookmarks right from the editor!
MIT License
207 stars 14 forks source link

Add ability to delete bookmarks #37

Open rkulla opened 1 year ago

rkulla commented 1 year ago

A keyboard shortcut to delete the selected bookmark(s) would be useful, especially for people who like to have a "Read Later" folder for reviewing tutorials, pull-requests, etc.

If this is possible, ideally it would have an optional confirmation prompt and maybe a second shortcut or option to automatically delete and open at the same time (to not have to go back into it to delete later).

Thanks for this very useful plugin!

dhruvmanila commented 1 year ago

Thanks for using the plugin! Good to know you find it useful :)

Deleting any bookmarks would involves updating the local bookmarks file which I'm not too sure about. The reason being that if the plugin did remove the entry, there's a chance that the file would become unreadable by the browser as it might expect it in a certain format.

We could determine the diff before and after a bookmark is removed by the browser to determine what kind of change should be done by the plugin to perform the same action but might involve some effort in doing so.

That said I'm not against supporting it, if anyone wants to contribute this feature I would be happy to help them. I might take a look at it when I get bored ;)