search

dhruvpatidar359 / nextdraw

A WhiteBoard application used for prototyping supports Websockets
https://nextdraw.vercel.app
MIT License
45 stars 29 forks source link

Panning using space click and mouse click isn't working, fixed it #59

Open a-khushal opened 6 months ago

a-khushal commented 6 months ago

after the introduction of panning using keyboard space click the delete button wan't working which was fixed by PR #46, but after this PR panning using space click isn't working.

how to reproduce the issue: try panning using space key and mouse click, it doesn't pan

Here's a ScreenCast showcasing the problem and the solution

Screencast from 19-05-24 04:59:49 PM IST.webm

The issue here is that the canvas isn't getting focused, so added tabIndex = 0 to the canvas object which fixes this issue

vercel[bot] commented 6 months ago

@a-khushal is attempting to deploy a commit to the dhruvpatidar359's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextdraw ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 2:56am
dhruvpatidar359 commented 6 months ago

@a-khushal Hi , everything works greate , but there is one issue with the undo and redo , have a look :

https://github.com/dhruvpatidar359/nextdraw/assets/103873587/a9844d3c-3886-4650-8d12-60ebc99ed100

Both the text and the color disappear simultanously . This is because , these two changes are included in the same state , we have to create this in two different states .

a-khushal commented 6 months ago

Alright, will work on it

a-khushal commented 5 months ago

@dhruvpatidar359 I have added layers to the same branch. Here's a screencast showing the working of layers Screencast from 06-06-24 11:36:47 PM IST.webm

a-khushal commented 5 months ago

@dhruvpatidar359 I have added layers to the same branch. Here's a screencast showing the working of layers Screencast from 06-06-24 11:36:47 PM IST.webm

Now how do I get this PR assigned under GSSOC, it's level3 also, I have pushed to the same PR, haven't raised a new one.

dhruvpatidar359 commented 5 months ago

@a-khushal I am impressed with this , just two things to consider more . Please put this into another PR , not in the same PR . We have to track each individual PR separate . second is there are some issues with the implementation .

Have a look : Again the Work is awesome .

https://github.com/dhruvpatidar359/nextdraw/assets/103873587/08143b10-417b-42ad-92d8-97f8669854cb

a-khushal commented 5 months ago

@dhruvpatidar359 please refer #76 this solves layers and the above shown issue