search

dhsanket / emote

emote afresh
2 stars 1 forks source link

Refactor UserActionController #68

Closed ostadhashem closed 10 years ago

nitinkarmuse commented 10 years ago

Hi Sina Can you explain what are these for UserDoing , UserEmotePoint I mean for what functionality These names are not intuitive to me

Regards Nitin

Sent from my iPhone

On 25 Sep 2013, at 11:20, Sina notifications@github.com wrote:

You can merge this Pull Request by running

git pull https://github.com/ostadhashem/emote master Or view, comment on, or merge it at:

https://github.com/dhsanket/emote/pull/68

Commit Summary

Some refactoring about domains of UserDoing.groovy, Merge remote-tracking branch 'remotes/upstream/master' Some refactoring about domains of UserDoing.groovy, File Changes

M emote.iws (342) M grails-app/controllers/com/emote/TitleController.groovy (25) A grails-app/controllers/com/emote/UserActionController.groovy (66) D grails-app/controllers/com/emote/UserDoingController.groovy (21) M grails-app/domain/com/emote/UserDoing.groovy (7) A grails-app/domain/com/emote/UserEmotePoint.groovy (38) M grails-app/services/com/emote/TitleService.groovy (20) A grails-app/services/emote/UserActionService.groovy (45) D grails-app/services/emote/UserDoingService.groovy (21) M grails-app/views/emote/_emotesTemplate.gsp (4) M web-app/js/emote.js (6) Patch Links:

https://github.com/dhsanket/emote/pull/68.patch https://github.com/dhsanket/emote/pull/68.diff

ostadhashem commented 10 years ago

Hi Nitin, When user press Doing now button in UI we save a new UserDoing for that. I will write javadoc for that, UserEmotePoint is wrong , because I missunderstood about #31 and I sould fix it, Regards, Sina

dhsanket commented 10 years ago

Nitin,

While Sina was waiting for the discussion on the 5 tasks estimation of time, I asked Sina to work on the Favourites and doingNow user actions. He has completed those and they are functional. They are also already on the live server.

Sanket