search

dhulihan / hooligan

A low-lit fully responsive theme for Jekyll-Bootstrap.
http://themes.jekyllbootstrap.com/preview/hooligan/
138 stars 43 forks source link

base.css full of errors #4

Closed emory closed 12 years ago

emory commented 12 years ago

The base.css this theme installs has a lot of garbage in it.

 Syntax error: Undefined mixin 'transition'.
    on line 35 of /media/Storage/Creative/Software/Projects/davehulihan.com/assets/themes/hooligan/_sass/base.scss, in `transition'
    from line 35 of /media/Storage/Creative/Software/Projects/davehulihan.com/assets/themes/hooligan/_sass/base.scss

Where would you recommend users (like myself) make changes to the style sheet? Should that be done exclusively via sass? Do you have a Rakefile that you use that creates the CSS I could see? This is a really great jekyll theme, you're very generous -- this is the first new theme I've seen in a long time.

dhulihan commented 12 years ago

Thanks for your feedback and for pointing this out! base.css is an old file that is no longer used, so I've deleted it in 061625.

For making changes, I'd recommend doing everything in sass, much easier. I use the jekyll compass plugin to generate the final css stored in assets/themes/hooligan/css.

For custom overrides, use assets/themes/hooligan/_sass/_custom.scss. I've marked that file as --assume-unchanged in git, so you can add any custom styling to that file that and it will be ignored by git, keeping the repo intact Hope this helps!