search

dhusemann / idlecombos

55 stars 17 forks source link

Please enter a valid Champ ID #20

Open SaintKatherine opened 2 years ago

SaintKatherine commented 2 years ago

Champ IDs 100 / 101 / 102 / 106 are all valid champs and return an error message unknown

djravine commented 2 years ago

Fixed, pending approval and merge

Fixed build: https://github.com/djravine/idlecombos

SaintKatherine commented 2 years ago

I imagine it will need updating again, with Valentines ID being available. Also it doesn't look like Nordom was added to the file? They are ID 100.

djravine commented 2 years ago

I have got the new ID's from http://idlechampions.soulreaver.usermd.net/champions.html

Nordom is already there on ID 100 - https://github.com/djravine/idlecombos/blob/3e785494b16d585fd300b49c9ca68512a2846c6b/idledict.ahk#L163

Valentine has been added on ID 103 - https://github.com/djravine/idlecombos/blob/3e785494b16d585fd300b49c9ca68512a2846c6b/idledict.ahk#L170

V (Soon) has been added on ID 104 (PLACEHOLDER) - https://github.com/djravine/idlecombos/blob/3e785494b16d585fd300b49c9ca68512a2846c6b/idledict.ahk#L171

If you use this repo, it will not download the updated dictionary until this is merged as the dictionary download is downloaded using this URL - https://github.com/dhusemann/idlecombos/blob/5ae25fa7dfdaa5447f9399d9ccea3add1cd39632/IdleCombos.ahk#L87

You should use my fork with the updated dictionary list until then.