search

dhutaryan / ngx-mat-timepicker

Material timepicker based on material design
https://dhutaryan.github.io/ngx-mat-timepicker/
MIT License
73 stars 8 forks source link

🚨Library styles affects global styling #149

Closed k3nsei closed 5 months ago

k3nsei commented 5 months ago

When I were trying to replace ngx-mat-timepicker from @tonysamperi (which is very shity quality and forces to use his luxon replacement library) with @dhutaryan/ngx-mat-timepicker. I found that provided mixin is affecting global scope styles. Giving some gray background to inputs, but they should stay white in my project.

image

I found those two places where this library styles are escaping to global scope and affect project styles.

https://github.com/dhutaryan/ngx-mat-timepicker/blob/cd8cedc6bffdd2c79232fbc748f385a5e90fcb40/projects/mat-timepicker/_timepicker-theme.scss#L96

https://github.com/dhutaryan/ngx-mat-timepicker/blob/cd8cedc6bffdd2c79232fbc748f385a5e90fcb40/projects/mat-timepicker/_timepicker-theme.scss#L105

k3nsei commented 5 months ago

@dhutaryan btw. could you also update the compatibility table in the readme by reversing the order to have the latest version of angular at the top? I think that way it would be more obvious, when I was reviewing this library to see if it was good enough to use, I almost skipped it because I thought it was super old and didn't support modern versions of angular.

dhutaryan commented 5 months ago

Good point. Thank you.

k3nsei commented 5 months ago

@dhutaryan I'm seeing that you already deploying fix. Thanks you for quick response and for that library <3

Finally I could remove this from my project. @tonysamperi should be burning in hell for forcing his shit to be bundled with UI component.

image

dhutaryan commented 5 months ago

Thank you.

Fixed in: 12.5.2 13.2.2 14.2.2 15.2.2 16.2.2 17.4.2