search

dhutaryan / ngx-mat-timepicker

Material timepicker based on material design
https://dhutaryan.github.io/ngx-mat-timepicker/
MIT License
75 stars 8 forks source link

Add support for Angular 18, Angular Material 18 and Material 3 design #168

Closed shhdharmen closed 4 months ago

shhdharmen commented 4 months ago

@dhutaryan Thanks for creating this awesome library. I am creating this PR to add support for below:

  1. Angular 18
  2. Angular Material 18
  3. Material 3 Design (keeping support for Material 2)

This should close #132 #152

shhdharmen commented 4 months ago

Attaching screenshots for easy review.

Screenshot 2024-06-27 at 11 34 45 AM Screenshot 2024-06-27 at 11 34 58 AM Screenshot 2024-06-27 at 11 35 31 AM Screenshot 2024-06-27 at 11 35 40 AM
howdysuraj commented 4 months ago

Nice

anabright commented 4 months ago

Thanks @shhdharmen! @dhutaryan any plans to merge & release this?

dhutaryan commented 4 months ago

@shhdharmen hey, thank you for that awesome work. I've started to work on it some time ago and wanted to add one more feature. I'm 100% sure we will have merge conflicts. So, if you don't mind I'll take some part of your changes to my branch. By the way, why did you change the size of fat buttons?

@anabright soon, didn't have time to handle it

shhdharmen commented 4 months ago

@dhutaryan yes, feel free to take my changes in your branch. Which buttons are you referring to? I tried to follow specs from https://m3.material.io/components/time-pickers/specs

anabright commented 4 months ago

No worries, thanks for your reply @dhutaryan, I just thought I'd give you a nudge ;)