Thanks!

[coderschoolreview]

Thanks for your submission. Everything looks good with it. We'll review and get back to you soon.

[avo1]

Hi @dhvan85 :+1: Good job with the Tip Calculator! Congratulations on finishing all the required and some optional user stories 🎉

Quick Comments:

• Good usage of NSUserDefaults. This is one of the methods to pass the data from multiple viewController. We will learn few more ways to do that. 1 minor thing, you create the defaults in SettingViewController but you never use it.
• Good job using NSNumberFormatter and CurrencyStyle.
• You shouldn't let the user enter invalid number, should you? I can enter bunch of leading zeros, and the dots. I can also paste some text in the text field.

• You should validate the user input from the Setting page. Percentage #1 < #2 < #3.
• I like the dark theme. Yellow on black is a good choice 👍

We'll email you about the class later. By the way, we are going to use Swift 3.0 (xcode 8). So it's good if you can try to upgrade your code to Swift 3 to get familiar with it now.

Regards, Dave

[dhvan85]

Thank you for your review, I'll clean up bugs :)

[dhvan85]

Hi Dave Vo,

I cleaned up it, and updated readme.

[avo1]

💯 good fix. But then you disable the decimal point on the keyboard. Just a minor thing.