search

dhylands / rshell

Remote Shell for MicroPython
MIT License
955 stars 137 forks source link

Python 3.10+ compatability issue with collections.Callable #227

Closed qwertychomp closed 6 months ago

qwertychomp commented 6 months ago

On my installation of Python 3.12.2, running rshell in command prompt returns the error "AttributeError: module 'collections' has no attribute 'Callable'". It turns out it was caused by something being changed in python3, and with python3 being the latest version of python, this should probably be fixed.

I've found that editing the line that causes the error (Line 8 in py3k_compat.py) fixes it (I found the solution in this article, but i don't know if it has any effects on other parts of rshell or python2 compatibility, so I'm submitting this issue instead.

By the way, this is the first issue I've ever submitted on GitHub so feel free to tell me if I've done anything wrong.

qwertychomp commented 6 months ago

Nevermind, it turns out it was an issue with a different package, pyreadline. Sorry for bothering you all!