search

dhylands / rshell

Remote Shell for MicroPython
MIT License
954 stars 135 forks source link

don't try to connect_telnet on Windows when '-p COMx' is specified #232

Closed github0null closed 3 months ago

github0null commented 3 months ago

Hello,

I noticed this case can't work on Windows, because windows serial port name usually is: 'COMxx', not include '/'

https://github.com/dhylands/rshell/blob/56f75cf846b2fd89f9a89c08a9dabd8015c30931/rshell/main.py#L1420-L1427

So it always try connect_telnet and elapse more time.

202

dhylands commented 3 months ago

So you've combined 3 different things in this MR. The thing about -p COMx, the tree command, and more verbose output for some of the commands.

Each one of these should be done as a separate PR.

github0null commented 3 months ago

Very sorry,

Since I was trying to develop something else on my fork, there were some junk commits, and i'll start over with a clean PR.