dhzdhd / Obsidian

A multipurpose discord bot written in dart.
https://obsidian-dhzdhd.vercel.app/
GNU Affero General Public License v3.0
6 stars 1 forks source link

Made basic UI for docs page #27

Closed ghost closed 2 years ago

ghost commented 2 years ago

Also formatted files with prettier

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dhzdhd/obsidian/F8yGQFdRvfFz3VvGvtEFoW15Rmf6
✅ Preview: https://obsidian-git-fork-akulbcodes-ui-docs-dhzdhd.vercel.app

ghost commented 2 years ago

Thanks for making the base blueprint for the documentation route!

The page is well done but needs a few changes.

* Format the entire file with the headwind tailwind formatter or any such formatter.

* The UI is not consistent with the landing page, try to fix that.

Headwind only works if a tailwind.config.js file is present

dhzdhd commented 2 years ago

Headwind only works if a tailwind.config.js file is present I think you can make a dummy tailwind config file for using headwind or find another formatter that does the job.

ghost commented 2 years ago

I can use the tailwind prettier plugin

dhzdhd commented 2 years ago

I can use the tailwind prettier plugin

Yeah I think that would be the best way of solving this issue.

ghost commented 2 years ago

image I am not very clear on what to do with this

ghost commented 2 years ago

image I feel like this can be centered to match the website homepage.

dhzdhd commented 2 years ago

image I feel like this can be centered to match the website homepage.

Sure, do it

dhzdhd commented 2 years ago

The Obsidian documentation top heading can be smaller to be more consistent with the main page

ghost commented 2 years ago

The Obsidian documentation top heading can be smaller to be more consistent with the main page

done

ghost commented 2 years ago

Wait is this the heading you meant

dhzdhd commented 2 years ago

Wait is this the heading you meant

Yes

ghost commented 2 years ago

any more changes?

dhzdhd commented 2 years ago

any more changes?

Increase the header height to be more consistent with the main page

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
obsidian ✅ Ready (Inspect) Visit Preview May 8, 2022 at 0:31AM (UTC)
ghost commented 2 years ago

any more changes?

Increase the header height to be more consistent with the main page

It's done now I think

dhzdhd commented 2 years ago

any more changes?

Increase the header height to be more consistent with the main page

It's done now I think

Are the latest changes formatted with prettier? If so, the code is ready to be merged

ghost commented 2 years ago

any more changes?

Increase the header height to be more consistent with the main page

It's done now I think

Are the latest changes formatted with prettier? If so, the code is ready to be merged

Yes, there really were no files to format since I just added one utility class

dhzdhd commented 2 years ago

LGTM

ghost commented 2 years ago

Thanks, very cool