di-sukharev / opencommit

Generate conventional git commit messages with AI in 1 second 🤯🔫
https://www.npmjs.com/package/opencommit
MIT License
5.98k stars 318 forks source link

[Bug]: Updating to 3.0.0 breakes oco on Windows #247

Closed robertoandrade closed 1 year ago

robertoandrade commented 1 year ago

Opencommit Version

3.0.0

Node Version

20.2.0

NPM Version

9.6.6

What OS are you seeing the problem on?

Windows

What happened?

After upgrading from 2.4.2 to 3.0.0 oco no longer works on my Windows 11 machine:

image

Expected Behavior

Continue to working like before (or better)

Current Behavior

Node exception:

node:internal/validators:162
    throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:399:5)
    at validateString (node:internal/validators:162:11)
    at Object.join (node:path:433:7)
    at Object.<anonymous> (C:\Users\roberto\AppData\Roaming\npm\node_modules\opencommit\out\cli.cjs:21908:44)
    at Module._compile (node:internal/modules/cjs/loader:1255:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1309:10)
    at Module.load (node:internal/modules/cjs/loader:1113:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47 {
  code: 'ERR_INVALID_ARG_TYPE'
}

Possible Solution

Downgrading back to 2.4.2

Steps to Reproduce

npm i -g opencommit@2.4.2
oco -version
npm i -g opencommit@3.0.0
oco -version

Relevant log output

No response

di-sukharev commented 1 year ago

github closed it automatically, please check that its fixed with the latest 3.0.3 version publish, open the issue again, if not

robertoandrade commented 1 year ago

indeed it works! thanks, that was fast!

di-sukharev commented 1 year ago

@robertoandrade ;)