search

di / pytest-reqs

py.test plugin for checking requirements files
https://pypi.org/p/pytest-reqs
MIT License
25 stars 6 forks source link

setup.py: List pip as a dependency #23

Closed jayvdb closed 5 years ago

jayvdb commented 6 years ago

This is needed for especially Python 2.7 before pip was packaged by default with the standard library via ensurepip.

di commented 5 years ago

I don't think we need to declare pip as a dependency here. I think we can assume that since this package generally will need to be installed with pip, pip is already present, so I'm going to close this.

jayvdb commented 5 years ago

@di, I disagree with this quite strongly. It doesnt matter if we know it can be installed -- declaring it as a dependency is about metadata -- it tells other systems very important information about the package. For example, distro package creators use this information to add a dependency on their python*-pip package. Vulnerability databases use it. etc, etc.

And it isnt necessary on Python 2.7 to have pip .

di commented 5 years ago

@jayvdb Ok, can you rebase?

jayvdb commented 5 years ago

Well, it appears the problem has moved a little.

https://github.com/di/pip-api/pull/8