di / pytest-reqs

py.test plugin for checking requirements files
https://pypi.org/p/pytest-reqs
MIT License
25 stars 6 forks source link

Remove use of internal pip APIs #29

Closed di closed 5 years ago

di commented 5 years ago

This PR fixes #13 ("Don't use pip's internal API"). It does so by using pip-api, which wrap's pip's command-line interface. Avoiding importing the internal API all together will ensure that this project is easier to maintain as pip changes, and will be more likely to support future versions, as the command-line interface changes much less frequently than the internal API.

As a result, it also fixes #17. Closes #18, closes #22, closes #28. (@jayvdb and @danie1k, thanks very much for these stop-gap PRs, but ultimately I think this is a more sustainable approach).

danie1k commented 5 years ago

Nice job, I like pip_api :)