search

di / pytest-reqs

py.test plugin for checking requirements files
https://pypi.org/p/pytest-reqs
MIT License
25 stars 6 forks source link

setup.py: Reduce min dependency packaging>=16.8 #32

Closed jayvdb closed 6 years ago

jayvdb commented 6 years ago

Previously set at 17.1

jayvdb commented 6 years ago

Note that I have done builds with this and https://github.com/di/pytest-reqs/pull/33 combined.

I dont mind if a higher packaging version is needed in the future, but it should be when there are mandatory features being used.

Currently coala has 16.8 pinned because of problems with using latter versions, which we could workaround in other ways, but ideally not until there is a good reason to do so.

di commented 6 years ago

If we're going to specify a lower bound here, I'd prefer if it is not a result of some external constraint. I just set the lower bound to packaging>=16.1 for pip-api and I think we can go at least this low here.

I also don't think we need to test against all versions of packaging, that's a big test matrix!

di commented 6 years ago

I take that back: fixing #37 via #41 requires packaging>=17.1, so this needs to stay as-is.