di / pytest-reqs

py.test plugin for checking requirements files
https://pypi.org/p/pytest-reqs
MIT License
25 stars 6 forks source link

setup.py: Use proper hyphenation of pip-api #46

Open jayvdb opened 5 years ago

jayvdb commented 5 years ago

Replaces pip_api with pip-api.

jayvdb commented 5 years ago

Split off from #24 . This simplify testing , other pytest-reqs fails its own requirements without also adding name normalisation logic everywhere.

di commented 5 years ago

We should be normalizing the name instead, see #47.

jayvdb commented 5 years ago

So you are using this projects setup.py as part of the test suite?

di commented 5 years ago

Not sure I follow... CI is currently passing without this change.

jayvdb commented 5 years ago

But you are not merging this PR. Do you want to keep setup.py using pip_api ? Why?