search

di2ag / Connections-Hypothesis-Provider-Roadmap

Contains milestones, both internal to CHP and external to NCATS, as well as development deliverables.
Apache License 2.0
0 stars 1 forks source link

Add interpolation support to CHP Joint Reasoner #5

Closed GregHydeDartmouth closed 2 years ago

GregHydeDartmouth commented 3 years ago

Found in CHP repo at Issue 59

Is your feature request related to a problem? Please describe. Simple queries sometimes return -1 because they default to the CHP Joint Reasoner which doesn't have interpolation currently activated as it wasn't fully tested yet.

Describe the solution you'd like Fully test interpolation support for Joint Reasoner first in the PyBKB mixin and then update the CHP Joint Reasoner Mixin appropriately.

Describe alternatives you've considered

Keep returning -1 and clarify to users what this means in a query response. If an answer isn't found in the Joint Reasoner (i.e. a -1 is returned) Run query through CHP Dynamic Reasoner which has interpolation support. Additional context N/A

GregHydeDartmouth commented 2 years ago

This is now supported from this commit