diStyApps / VisionCrafter

Craft your visions
130 stars 9 forks source link

[Feature Request] init image support #1

Closed toyxyz closed 1 year ago

toyxyz commented 1 year ago

Thanks for the great work! In addition to the prompts, it would be cool to add the ability to generate an animation based on a specific initial image! Like the one in this repo, : https://github.com/rynmurdock/inanimate https://github.com/talesofai/AnimateDiff image

diStyApps commented 1 year ago

Thank you very much, i am aware of that and i plan to add it.

toyxyz commented 1 year ago

This guy's work looks amazing too! https://github.com/ykk648/AnimateDiff image

257777597-16c7079c-f6da-4316-aeca-e63b2c777529 257777301-b8ece59f-54b1-4bab-b18d-7d038be4dbc6

Ainaemaet commented 1 year ago

testing out this repo currently, as it contains both long-form code and I2V (init image) - it seems to work really well! I do, however like the looks/usability here better and it seems you are quite active in development compared to many authors - so really looking forwards to that init-image availability!! :)

diStyApps commented 1 year ago

Added, soon ill add proper UI for it.

Ainaemaet commented 1 year ago

Very happy to hear that. Thankyou πŸ™‚


From: diStyApps @.> Sent: 14 August 2023 13:09 To: diStyApps/VisionCrafter @.> Cc: Ainaemaet @.>; Comment @.> Subject: Re: [diStyApps/VisionCrafter] [Feature Request] init image support (Issue #1)

Added, soon ill add proper UI for it.

β€” Reply to this email directly, view it on GitHubhttps://github.com/diStyApps/VisionCrafter/issues/1#issuecomment-1677913671, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACPAAFGLI6BOZ4RO2TA55MDXVJZX3ANCNFSM6AAAAAA3AT44NE. You are receiving this because you commented.Message ID: @.***>

AsaTyr2018 commented 1 year ago

Very happy to hear that. Thankyou πŸ™‚ … ____ From: diStyApps @.> Sent: 14 August 2023 13:09 To: diStyApps/VisionCrafter @.> Cc: Ainaemaet @.>; Comment @.> Subject: Re: [diStyApps/VisionCrafter] [Feature Request] init image support (Issue #1) Added, soon ill add proper UI for it. β€” Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACPAAFGLI6BOZ4RO2TA55MDXVJZX3ANCNFSM6AAAAAA3AT44NE. You are receiving this because you commented.Message ID: @.***>

can you check the feature for yourself and give a little feedback? =)

Ainaemaet commented 1 year ago

Certainly! I was a little busy last coupledays but I've been excited about this project for a while now. :) Doing the install as I type this; I'm running in wsl2 and don't really have the room atm to re dl all the models again, can I use cl switches to redirect to my already existing animatediff and automatic models folders, or do I need to set them in main.py?

On Wed, Aug 16, 2023, 1:31 a.m. AsaTyr2018 @.***> wrote:

Very happy to hear that. Thankyou πŸ™‚ … <#m-2897197363737361595> ____ From: diStyApps @.> Sent: 14 August 2023 13:09 To: diStyApps/VisionCrafter @.> Cc: Ainaemaet @.>; Comment @.> Subject: Re: [diStyApps/VisionCrafter] [Feature Request] init image support (Issue #1 https://github.com/diStyApps/VisionCrafter/issues/1) Added, soon ill add proper UI for it. β€” Reply to this email directly, view it on GitHub<#1 (comment) https://github.com/diStyApps/VisionCrafter/issues/1#issuecomment-1677913671>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPAAFGLI6BOZ4RO2TA55MDXVJZX3ANCNFSM6AAAAAA3AT44NE. You are receiving this because you commented.Message ID: @.***>

can you check the feature for yourself and give a little feedback? =)

β€” Reply to this email directly, view it on GitHub https://github.com/diStyApps/VisionCrafter/issues/1#issuecomment-1680105508, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPAAFAXQBZGSWFHZQSR3T3XVRZMTANCNFSM6AAAAAA3AT44NE . You are receiving this because you commented.Message ID: @.***>

toyxyz commented 1 year ago

It works well! It would be cooler without the resolution limit (512x512).

https://github.com/diStyApps/VisionCrafter/assets/8006000/0b57145d-9cdf-4ce2-8f56-6b1bbfde7b04

https://github.com/diStyApps/VisionCrafter/assets/8006000/e3b422b7-c388-4b25-ad92-a04da87be79d

Init image

ComfyUI_0494

ComfyUI_0495

AsaTyr2018 commented 1 year ago

Certainly! I was a little busy last coupledays but I've been excited about this project for a while now. :) Doing the install as I type this; I'm running in wsl2 and don't really have the room atm to re dl all the models again, can I use cl switches to redirect to my already existing animatediff and automatic models folders, or do I need to set them in main.py? … On Wed, Aug 16, 2023, 1:31 a.m. AsaTyr2018 @.> wrote: Very happy to hear that. Thankyou πŸ™‚ … <#m-2897197363737361595> ____ From: diStyApps @.> Sent: 14 August 2023 13:09 To: diStyApps/VisionCrafter @.> Cc: Ainaemaet @.>; Comment @.> Subject: Re: [diStyApps/VisionCrafter] [Feature Request] init image support (Issue #1 <#1>) Added, soon ill add proper UI for it. β€” Reply to this email directly, view it on GitHub<#1 (comment) <#1 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPAAFGLI6BOZ4RO2TA55MDXVJZX3ANCNFSM6AAAAAA3AT44NE. You are receiving this because you commented.Message ID: @.> can you check the feature for yourself and give a little feedback? =) β€” Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPAAFAXQBZGSWFHZQSR3T3XVRZMTANCNFSM6AAAAAA3AT44NE . You are receiving this because you commented.Message ID: @.***>

You can do it like me: I have a central storage with models, LORAs, etc. on a network share. I simply created a symlink. This way, the system thinks the files are in the local folder, but it doesn't take up more storage (since it's a network share). You can also use local shares on a separate hard disk. Network sharing only applies if you have a strong and consistently stable network connection (1 Gbps and up).

Keep me updated once you tested it.

AsaTyr2018 commented 1 year ago

It works well! It would be cooler without the resolution limit (512x512). 0-masterpiece.-best-quality.-1girl.-solo.-blonde-hair.-white-bikini.-blue.mp4 results_grid.mp4

Init image

ComfyUI_0494

ComfyUI_0495

yes i was thinking the same. might change in the future. At last the feature is in and its working =) Rest is finetuning. Thank you for the Examples.

rbychn commented 1 year ago

has this been added to the UI? Does it need VAE or clip skip? The example by @toyxyz seems to lack a bit or texture or colors compared to the outputs one would get from https://github.com/neggles/animatediff-cli

AsaTyr2018 commented 1 year ago

has this been added to the UI? Does it need VAE or clip skip? The example by @toyxyz seems to lack a bit or texture or colors compared to the outputs one would get from https://github.com/neggles/animatediff-cli

It has been addet. currently its pretty basic. grafik

VAE and Clip isnΒ΄t availible atm. But will be added in futher updates.

diStyApps commented 1 year ago

has this been added to the UI? Does it need VAE or clip skip? The example by @toyxyz seems to lack a bit or texture or colors compared to the outputs one would get from https://github.com/neggles/animatediff-cli

Hey, the clip skip will take a while and what you mean by VAE, custom VAE ?

rbychn commented 1 year ago

@AsaTyr2018 thanks, it'd be good to update the UI images in the repo examples. I looked at that and thought this feature is not in the UI yet hence didn't try. Btw, is there a way to increase the init max size? currently getting an error stating on 512x512 is allowed.

@diStyApps That's good to know, and yes, maybe custom VAE in advanced options somewhere, but I think clip skip would fix most of these issues depending on the models used.

Ainaemaet commented 1 year ago

Certainly! I was a little busy last coupledays but I've been excited about this project for a while now. :) Doing the install as I type this; I'm running in wsl2 and don't really have the room atm to re dl all the models again, can I use cl switches to redirect to my already existing animatediff and automatic models folders, or do I need to set them in main.py? … On Wed, Aug 16, 2023, 1:31 a.m. AsaTyr2018 @._> wrote: Very happy to hear that. Thankyou πŸ™‚ … <#m-2897197363737361595> __ From: diStyApps @.> Sent: 14 August 2023 13:09 To: diStyApps/VisionCrafter @.> Cc: Ainaemaet @.>; Comment @.> Subject: Re: [diStyApps/VisionCrafter] [Feature Request] init image support (Issue #1 <#1>) Added, soon ill add proper UI for it. β€” Reply to this email directly, view it on GitHub<#1 (comment) <#1 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPAAFGLI6BOZ4RO2TA55MDXVJZX3ANCNFSM6AAAAAA3AT44NE. You are receiving this because you commented.Message ID: @.**> can you check the feature for yourself and give a little feedback? =) β€” Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPAAFAXQBZGSWFHZQSR3T3XVRZMTANCNFSM6AAAAAA3AT44NE . You are receiving this because you commented.Message ID: @_.***>

You can do it like me: I have a central storage with models, LORAs, etc. on a network share. I simply created a symlink. This way, the system thinks the files are in the local folder, but it doesn't take up more storage (since it's a network share). You can also use local shares on a separate hard disk. Network sharing only applies if you have a strong and consistently stable network connection (1 Gbps and up).

Keep me updated once you tested it.

Would you be able to help with what command you use to symlink in your Ubuntu? Using the regular windows methods doesn't work with a wsl filesystem and I'm having a difficult time finding a properly working method online.

AsaTyr2018 commented 1 year ago

Certainly! I was a little busy last coupledays but I've been excited about this project for a while now. :) Doing the install as I type this; I'm running in wsl2 and don't really have the room atm to re dl all the models again, can I use cl switches to redirect to my already existing animatediff and automatic models folders, or do I need to set them in main.py? … On Wed, Aug 16, 2023, 1:31 a.m. AsaTyr2018 @._> wrote: Very happy to hear that. Thankyou πŸ™‚ … <#m-2897197363737361595> __ From: diStyApps @.> Sent: 14 August 2023 13:09 To: diStyApps/VisionCrafter @.> Cc: Ainaemaet @.>; Comment @.> Subject: Re: [diStyApps/VisionCrafter] [Feature Request] init image support (Issue #1 <#1>) Added, soon ill add proper UI for it. β€” Reply to this email directly, view it on GitHub<#1 (comment) <#1 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPAAFGLI6BOZ4RO2TA55MDXVJZX3ANCNFSM6AAAAAA3AT44NE. You are receiving this because you commented.Message ID: @.**> can you check the feature for yourself and give a little feedback? =) β€” Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPAAFAXQBZGSWFHZQSR3T3XVRZMTANCNFSM6AAAAAA3AT44NE . You are receiving this because you commented.Message ID: @_.***>

You can do it like me: I have a central storage with models, LORAs, etc. on a network share. I simply created a symlink. This way, the system thinks the files are in the local folder, but it doesn't take up more storage (since it's a network share). You can also use local shares on a separate hard disk. Network sharing only applies if you have a strong and consistently stable network connection (1 Gbps and up). Keep me updated once you tested it.

Would you be able to help with what command you use to symlink in your Ubuntu? Using the regular windows methods doesn't work with a wsl filesystem and I'm having a difficult time finding a properly working method online.

I donΒ΄t use ubuntu/linux in my setup. only my media server use it. But just in case. check the FSTAB

Works best in my opinion. here is a suitable guide: https://timlehr.com/2018/01/auto-mount-samba-cifs-shares-via-fstab-on-linux/index.html

Ainaemaet commented 1 year ago

Really looking forwards to it. I had to give up for the time being as trying to get everything working with my setup wasn't going so well!

It really is a wonderful project tho. :)


From: toyxyz @.> Sent: 16 August 2023 03:12 To: diStyApps/VisionCrafter @.> Cc: Ainaemaet @.>; Comment @.> Subject: Re: [diStyApps/VisionCrafter] [Feature Request] init image support (Issue #1)

It works well! It would be cooler without the resolution limit (512x512).

https://github.com/diStyApps/VisionCrafter/assets/8006000/0b57145d-9cdf-4ce2-8f56-6b1bbfde7b04

Init image

[ComfyUI_0494]https://user-images.githubusercontent.com/8006000/260960442-227c6621-0705-4bbb-8079-952cf1cef492.png

β€” Reply to this email directly, view it on GitHubhttps://github.com/diStyApps/VisionCrafter/issues/1#issuecomment-1680246014, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACPAAFFBMMHCAA7QPZWZ4FTXVSFHXANCNFSM6AAAAAA3AT44NE. You are receiving this because you commented.Message ID: @.***>

AsaTyr2018 commented 1 year ago

Really looking forwards to it. I had to give up for the time being as trying to get everything working with my setup wasn't going so well! It really is a wonderful project tho. :) … ____ From: toyxyz @.> Sent: 16 August 2023 03:12 To: diStyApps/VisionCrafter @.> Cc: Ainaemaet @.>; Comment @.> Subject: Re: [diStyApps/VisionCrafter] [Feature Request] init image support (Issue #1) It works well! It would be cooler without the resolution limit (512x512). https://github.com/diStyApps/VisionCrafter/assets/8006000/0b57145d-9cdf-4ce2-8f56-6b1bbfde7b04 Init image [ComfyUI_0494]https://user-images.githubusercontent.com/8006000/260960442-227c6621-0705-4bbb-8079-952cf1cef492.png β€” Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACPAAFFBMMHCAA7QPZWZ4FTXVSFHXANCNFSM6AAAAAA3AT44NE. You are receiving this because you commented.Message ID: @.***>

glad to read it =) Its @diStyApps heartblood.

i would close this ticket for now since init image support is availible. In case of an Issue, open a new Incedent please =)