search

diabase / H-Series-Wizard

Source code for the H-Series machine wizard and post-processor
3 stars 4 forks source link

toolChangeRetractionDistance and toolChangeRetractionSpeed not updated #6

Closed martijnschouten closed 5 years ago

martijnschouten commented 5 years ago

Hi,

We currently are having the problem that after we cleaned our extruders using the super fancy nozzle cleaning system, still some filament is extruded before the actual print starts. This makes the cleaning pretty much useless.

To reduce this problem I tried changing the tool change retraction distance in Simplify, however it doesn't do anything. This appears to be due to the toolChangeRetractionDistance and the toolChangeRetractionSpeed variables not being updated from their default settings.

This happens because in the FindParameter function there are these lines 

if (c == ';')
{
    break;
}

Which makes that the function doesn't work for lines which are commented out. Removing these lines seems to fix the issue. Was there a reason why these lines were there at all?

wilriker commented 5 years ago

Hi!

The FindParameter function is supposed to... find parameters of a GCode command. Since every command ends at either line break or the start of a comment it can stop searching the string because even if the requested parameter is discovered after that it would not be executed by the firmware, e.g.

G1 X10 ; Y100 Z50

must not return a value for parameter Y or Z since these are meaningless.

Nevertheless I will have a look at the variables you mentioned that are not being updated early next week.

wilriker commented 5 years ago

@martijnschouten Is it possible to provide GCode (preferably the output of S3D) that exhibits this problem? That will probably make it easier to find the issue.

martijnschouten commented 5 years ago

Sure, I attached one file as exported form simplify, using process 4 of the attached factory file. The other file is the result when I process the gcode file from simplify in the post processor on my system. The parameters toolChangeRetractionDistance and toolChangeRetractionSpeed are in the area in the beginning of the unprocessed file that is commented out. rotorTest_rev10.zip

wilriker commented 5 years ago

I think you already solved this issue within your own solution to #7 where it is the missing Culture information. But I will check that.

wilriker commented 5 years ago

I pushed a commit that allows these comment lines to be read. It seems to fix your issue. Can you please verify this and close this issue if it's fixed?

martijnschouten commented 5 years ago

I checked the new version this issue is now solved, thank you!