search

diablodiab / libretro-scummvm-backend

libretro backend for scummvm
7 stars 8 forks source link

added define LS = ls #14

Closed asciibeats closed 1 year ago

asciibeats commented 2 years ago

I needed to add that line to make it compile. Without it LS is not defined in scummvm/rules.mk line 87 and compilation fails with error 127. Maybe something changed upstream? Anyways, thank you for your work! Very happy about it!

i30817 commented 2 years ago

Yes, this error is new. Since this version of the core, doesn't use the libretro fork at all, it might even be a upstream problem. Is the rules.mk file from upstream?

edit: ah, i guess since you modified the makefile for this project to fix it, that upstream has it handled in their own since there is not a reported bug there.

asciibeats commented 2 years ago

Is the rules.mk file from upstream?

Yes

DrUm78 commented 1 year ago

Indeed that fixes the issue. I had to comment line 87 in the Makefile before to fix it, thanks. 👍