search

diablodiab / libretro-scummvm-backend

libretro backend for scummvm
7 stars 8 forks source link

Freeze at exit on many games due to recent ScummVM modification on "quit prompt" #25

Closed schmurtzm closed 1 year ago

schmurtzm commented 1 year ago

Hi, the modification from this commit has a bad impact on Retroarch exit on many games (probably at least all SCUMM engine games).

On my device (Miyoo Mini) it freeze on the last image of the game displayed and never quit retroarch. May be it isn't displaying the "quit prompt" and wait for a key to exit which is not mapped on my device ?

A workaround is to modify all the _messageBannerActive = true; lines with false value (for example on this line )

Then Retroarch is able to quit in a normal way again.

DrUm78 commented 1 year ago

You can also disable the new code this way.

schmurtzm commented 1 year ago

You can also disable the new code this way.

Probably a more elegant way, thank you very much :)

diablodiab commented 1 year ago

I've adjusted the backend to deal with this without adjusting the scummvm base.

DrUm78 commented 1 year ago

@diablodiab Does not work for me, I'm still stuck on my handheld console when trying to quit a game, I still need to comment the code this way: https://github.com/DrUm78/scummvm/commit/21201c215537bb800bb70580c78cb62b374dc1ca#diff-2fcafec02bc595adbb461884d5b54acf5a5045ab8d6778eeec8dc013c00ba78a

diablodiab commented 1 year ago

Works when I've tested on MacOS and Android - problem was there before and now no longer.

As an alternative workaround, you can set the following setting in your scummvm.ini for the Scumm engine games: original_gui=false

diablodiab commented 1 year ago

Also, be aware that this change is not on the build bot.

DrUm78 commented 1 year ago

Only my way worked for me. I have no problem with modifying the upstream as anyway I have to do it for my target device (FunKey S). And I do not use the build bot as I compile myself the Libretro core.

spleen1981 commented 1 year ago

@diablodiab the workaround in https://github.com/diablodiab/libretro-scummvm-backend/commit/96a63485f3be7888f15cd66215d1e4eaf9d3070b is not guaranteed to work for 2 reasons: