Consider centralising some implementation that all metrics have in common

[clange]

• getQualityProblems looks the same for all metrics (and is currently copied). Can't we centralise it into some common superclass instead of only having a Metric super-interface?
• Some metrics have a before method, others don't. If this same work were done in a constructor, it would be easier to do this in a constructor because then it would be done automatically when initialising the metric.

[jerdeb]

• getQualityProblems can be done in the AbstractQualityMetric class.
• the before method is just used in a complex metric. please do not use constructors!!

On 15 July 2014 19:33, Christoph Lange notifications@github.com wrote:

• getQualityProblems looks the same for all metrics (and is currently copied). Can't we centralise it into some common superclass instead of only having a Metric super-interface?
• Some metrics have a before method, others don't. If this same work were done in a constructor, it would be easier to do this in a constructor because then it would be done automatically when initialising the metric.

— Reply to this email directly or view it on GitHub https://github.com/diachron/quality/issues/48.