search

diachron / quality

Dataset Quality Assessment (part of WP5 of the Diachron EU FP7 project)
MIT License
8 stars 4 forks source link

ProblemList issues. #56

Closed kovrus closed 5 years ago

kovrus commented 9 years ago

There are some small issues with the ProblemList data type.

  1. If there have been none problems found for an arbitrary metric, a ProblemList instance would be init with an empty list instance. Here we access the 0-index of the list, which, of course, throws an exception. Also, maybe we can think about removing the init exception throwing, because we, anyway, catch it and treat it as a checked exception in the getQualityProblems method. Instead we can return just an empty instance of a list.
  2. It would be nice to implement a list interface for this particular data structure, not to have constructions like problemListInstance.getProblemList.size()which is Demeter violation.