search

diafygi / acme-tiny

A tiny script to issue and renew TLS certs from Let's Encrypt
MIT License
4.73k stars 572 forks source link

account can not be registered on bypass.no #241

Closed imhfg0ar closed 3 years ago

imhfg0ar commented 4 years ago

# create account, update contact details (if any), and set the global key identifier will not work with independend norwegian registrar if you do it exactly as described (and acme-tiny does ;-) - first try to register empty account, and add email contact ever after. Because they just would not accept registrations without email, so it will fail before getting any chance to update it.

The ugly hack 

     reg_payload = {"termsOfServiceAgreed": True}
+    if contact is not None:
+     log.info(contact)
+     reg_payload = {"termsOfServiceAgreed": True, "contact": contact}

does the job

richfelker commented 3 years ago

This also happens with buypass.com and possibly other providers. I think the fix here should be applied if there's no better proposal.

diafygi commented 3 years ago

@richfelker @imhfg0ar can you please review pull #267 to see if acme-tiny now works for your other CAs?

richfelker commented 3 years ago

I was unable to get it to work in the context I was trying to use it for other reasons (IPv6 troubles), but the patch made the original registration succeed.

diafygi commented 3 years ago

Merged!

imhfg0ar commented 3 years ago

Thanks, @diafygi ! Tested HEAD on bypass test ca, no issues. (sorry for late reply, github's paranoia prevented me to login)