search

diafygi / webcrypto-examples

Web Cryptography API Examples Demo: https://diafygi.github.io/webcrypto-examples/
GNU General Public License v2.0
1.64k stars 194 forks source link

IE11 fixes with mscrypto-adapter.js #17

Closed vibornoff closed 8 years ago

vibornoff commented 8 years ago

Additionally, AES-GCM iv parameter length is restricted to 12 octets

diafygi commented 8 years ago

Won't allow this project to have dependencies. Please create two pull requests: (1) with the 12 octet modification, (2) with the IE11 fix without dependencies.

vibornoff commented 8 years ago

What do you mean "without dependencies"? Should I remove git dependency only or it would be better to add core-js/shim.min.js and mscrypto-adapter.js copies?

diafygi commented 8 years ago

Yes, please remove shim.min.js and mscrypto-adapter.js. No outside scripts should be depended on to run these examples.

vibornoff commented 8 years ago

Note that IE11 implements deprecated version of the Web Crypto API spec. It doesn't rely on Promises and it has a bit different parameters/return values syntax for at least AES-GCM (see mscrypto-adapter code for more details). So it's mandatory to have both the Promise implementation and the Web Crypto API adapter to make IE11 work properly.

diafygi commented 8 years ago

This is a live table showing support for the standard, so if IE11 doesn't implement the standard, it should fail the test.

vibornoff commented 8 years ago

Ok, it's up to you.