search

diafygi / webcrypto-examples

Web Cryptography API Examples Demo: https://diafygi.github.io/webcrypto-examples/
GNU General Public License v2.0
1.64k stars 194 forks source link

Change HKDF-CTR to HKDF #54

Open LiraNuna opened 6 years ago

LiraNuna commented 6 years ago

Summary This PR removes the HKDF-CTR algorithm, which was removed from webcrypto, in favor of HKDF.

There are two changes: one for the documentations in README.md and the other for the live table tester table.

Test Plan This was tested against Chrome 67.0.3396.79. All implementations pass correctly. chrome

This was also tested against Firefox 60, however it seems to be throwing a An invalid or illegal string was specified exception on deriveKey, while deriveBits succeeds. I am unsure if the issue is my implementation or an issue with Firefox.

screenshot from 2018-06-10 00-54-14

Fixes #46

LiraNuna commented 6 years ago

According to https://github.com/w3c/webcrypto/issues/193#issuecomment-396075911, it's actually good that deriveKey doesn't work on Firefox. In addition, other deriveKey work - I'm not concerned about this anymore.