search

diagonalworks / diagonal-b6

b6: Diagonal's geospatial analysis engine.
Apache License 2.0
23 stars 3 forks source link

unrendered features need rendering if selected #285

Open gacafe opened 1 month ago

gacafe commented 1 month ago

I added some point data, then I found it using the cli - the ui moves the view to be centered around the point, but the point does not render, because we dont render points. so you still dont know where it is.

Image

biamalveiro commented 1 month ago

Ah looks like a bug, we should render points if they have a geometric attribute. I'll have a look. To help me reproduce the issue, can you let me know what expression you use to find the point in the CLI?

gacafe commented 1 month ago

this happens the same with areas too. if an area is not rendered normally, then when you find one and click on it, it does not show on the map.

biamalveiro commented 1 month ago

hey @andreweland, @gacafe and I and a look around the issue and were able to narrow down the cause. The frontend expects the stack response to be of the format:

{
    proto: UIResponseProto;
    geoJSON: FeatureCollection[];
};

and the data in geoJSON determines what to render on the map for the respective outliner. It seems that this geoJSON in the response is undefined for those cases.