search

diagrams / SVGFonts

Fonts from the SVG-Font format
http://hackage.haskell.org/package/SVGFonts
Other
20 stars 12 forks source link

what used to be small documentation changes #14

Closed robx closed 9 years ago

robx commented 9 years ago

The first 6 commits are small documentation and naming changes, which I originally wanted to submit as a pull request.

Apparently I don't understand github pull requests, though, since now quite a bit of refactoring slipped in. I think those are good, but they change the interface a bit. Let me know if I should bring this into some other shape.

I haven't tested the larger changes well since my diagrams code currently doesn't want to compile against diagrams from git.

robx commented 9 years ago

I've since tested this, works fine. Logs parsing errors as before, but continues without the offending characters.

tkvogt commented 9 years ago

All reasonable changes. It is more natural to make the text argument outside of the options. Thanks. I will also so some changes soon. I want to make SVGFonts be based on svg-diagrams.