search

diagrams / diagrams-contrib

User-contributed extensions to diagrams
BSD 3-Clause "New" or "Revised" License
27 stars 30 forks source link

Please lift the restriction on semigroups 0.12 #25

Closed peti closed 10 years ago

peti commented 10 years ago

Your package compiles fine with the latest version of semigroups after the restrictions in the Cabal file have been lifted.

bergey commented 10 years ago

I can confirm that cabal install core/ lib/ contrib/ svg/ -j --constraint=semigroups==0.12 dual-tree/ monoid-extras/ active/ works, after bumping the semigroups constraints on all 6 packages. (svg doesn't actually have a semigroups dependency.)

It looks as though semigroups-0.12 is all additions, no API changes.

@byorgey Is it OK if I just push these to the respective master branches?

byorgey commented 10 years ago

Yes, it looks like semigroups-0.12 adds a class instance for Const, which according to the PVP requires a major version bump (because it breaks any code which had declared an orphan instance). But it shouldn't affect us since we don't have an orphan instance for Const. Go ahead and push, and I'll put out some minor releases (I have a script for doing the process quickly).

bergey commented 10 years ago

Done. Thanks for the explanation about the orphan instance issue; I did not understand that before.

byorgey commented 10 years ago

Released monoid-extras-0.3.2.4, dual-tree-0.2.0.1, active-0.1.0.10, diagrams-core-1.0.0.1, diagrams-lib-1.0.0.1, and diagrams-contrib-1.0.0.1.