search

diagrams / diagrams-contrib

User-contributed extensions to diagrams
BSD 3-Clause "New" or "Revised" License
27 stars 30 forks source link

Add a module for drawing grids with annotations #33

Closed idontgetoutmuch closed 10 years ago

idontgetoutmuch commented 10 years ago

I can't get diagrams-haddock to work on my setup but maybe someone else can do this. Alternatively I can put the diagram the haddock is supposed to generate somewhere else.

byorgey commented 10 years ago

Looks great, thanks! I have just two requests:

  1. Please don't bump the version number as part of the pull request, we'll deal with that separately. (And in any case adding a new module requires bumping the third version component, not just the last.)
  2. This is sort of odd timing with things being in flux in master, etc. We are still figuring out how to deal with this sort of thing in general, but for now I have created a new branch called grid based on @8eca0c0. Can you close this pull request and open a new request to that branch instead of master? Then it should build cleanly and we can separately work on merging from grid into master soon.
idontgetoutmuch commented 10 years ago

This will get added to the branch "grid".