diagrams / diagrams-contrib

User-contributed extensions to diagrams
BSD 3-Clause "New" or "Revised" License
27 stars 30 forks source link

Grid Layout Module #39

Closed pnutus closed 10 years ago

pnutus commented 10 years ago

This module contains functions for putting a list of diagrams in a grid layout with minimal effort from the user. I find it very useful for comparing diagrams in a more space-efficient way than using hcat or vcat.

byorgey commented 10 years ago

Looks very nice, thanks! I just have a couple minor comments, interspersed above.

pnutus commented 10 years ago

Is it ready to be merged?

There's a few things to improve:

I don't have time to work on it right know since I'm teaching a university intro course for two weeks, but I'll tidy it up when that's over.

byorgey commented 10 years ago

Yes, I think it's ready to be merged --- we can always improve those things later. In particular if you want to rename things or change their types (e.g. gridCat') we can be sure to do that before making a release.