search

diagrams / diagrams-contrib

User-contributed extensions to diagrams
BSD 3-Clause "New" or "Revised" License
27 stars 31 forks source link

Remove arithmoi dependency #44

Closed byorgey closed 9 years ago

byorgey commented 9 years ago

arithmoi is causing problems for diagrams builds, because it now enables LLVM by default, so it fails to install for anyone who doesn't have LLVM installed (i.e. almost everyone). However, we only use it for factoring very small numbers, which is kind of like shooting a fly with a Howitzer at close range. We should just remove arithmoi and write our own (simple, brute-force) factoring method.

idontgetoutmuch commented 9 years ago

Lol - I just tripped over this a few hours ago but I believe that arithmoi can be installed without llvm

cabal install arithmoi -f -llvm

Can we demand that arithmoi is installed in this way?

BTW more fun - if you happen to install llvm 3.5 (which seems to be the latest) then arithmoi fails to build as ghc 7.8.3 doesn't support 3.5. If you install 3.4 then all works. It's not an experience I would wish on other users though.

byorgey commented 9 years ago

That's the problem --- I don't think there is a way to specify a dependence on another library with a particular selection of flags.

cchalmers commented 9 years ago

Fixed with d3fb199.