diagrams / diagrams-contrib

User-contributed extensions to diagrams
BSD 3-Clause "New" or "Revised" License
27 stars 31 forks source link

Add Diagrams.Anchors #63

Closed bch29 closed 8 years ago

bch29 commented 8 years ago

Moving this to diagrams-contrib instead of diagrams-lib as suggested. Original pull request.

First up, thanks for having a look at this! It's no problem that it took a while, I have no urgent need to get this merged.

To answer the comments in the last post there:

byorgey commented 8 years ago
byorgey commented 8 years ago

I think the Travis build is failing because you need to add a DeriveDataTypeable extension.

Also, to be clear, my suggestions re: more variants for withAnchors and addAnchor are just suggestions for improvement, not requirements for merging. I can merge it as soon as the Travis build is fixed, and we can continue to improve it.

byorgey commented 8 years ago

Closer, now it only fails on GHC 8 because of some redundant constraints:

src/Diagrams/Anchors.hs:99:10: warning: [-Wredundant-constraints]
    • Redundant constraints: (Additive (V t), Num (N t))
    • In the instance declaration for ‘Transformable (Anchored t)’

src/Diagrams/Anchors.hs:122:10: warning: [-Wredundant-constraints]
    • Redundant constraint: Show (N t)
    • In the instance declaration for ‘Show (Anchored t)’