search

diagrams / diagrams-contrib

User-contributed extensions to diagrams
BSD 3-Clause "New" or "Revised" License
27 stars 31 forks source link

Diagrams.TwoD.Grid provides gridWithHalves', but does not export GridOpts #68

Closed jwiegley closed 7 years ago

jwiegley commented 7 years ago

https://hackage.haskell.org/package/diagrams-contrib-1.4.0.1/docs/Diagrams-TwoD-Grid.html

You can see that GridOpts is not a link, because there's no way to interact with it except to pass the default.

byorgey commented 7 years ago

Thanks! It looks like there are several other things not exported from that module either. Definitely an oversight. I wonder if the explicit export list was added as an afterthought. In any case, I should be able to fix this soon.

idontgetoutmuch commented 7 years ago

Thanks for fixing this - I feel guilty that I hadn't since it was my contribution.

byorgey commented 7 years ago

No need to feel guilty! To be honest I hadn't even looked to see who the original contributor was. All are welcome to chip in and fix whatever needs fixing regardless of who originally contributed what.