search

diagrams / diagrams-contrib

User-contributed extensions to diagrams
BSD 3-Clause "New" or "Revised" License
27 stars 31 forks source link

Add support for rotation constraints #88

Closed o1lo01ol1o closed 1 year ago

o1lo01ol1o commented 2 years ago

This PR adds support for rotation constraints in Diagrams.TwoD.Layout.Constrained. (Sorry for the formatting change, the auto-formatter got me.)

byorgey commented 2 years ago

Hi @o1lo01ol1o , thanks! Rotation constraints sounds exciting. However, the formatting changes are something of a problem simply because it makes it very difficult to tell exactly what the substantive changes are, and hence difficult to review. Would you mind redoing this without the formatting changes? You could either force-push to your branch, or close this PR and open a new one, either would be fine. Happy to help if you're unsure of the best way to do that.

o1lo01ol1o commented 1 year ago

@byorgey I would have rebased and selectively commit the changes, but I ran into complications with the metafont solver; iirc, the additional constraints would throw errors about redundant constraints unless the system was fairly trivial. Feel free to close this, I'm not sure when I'll go back into it.

byorgey commented 1 year ago

@o1lo01ol1o ah, ok, no worries. I'll close this then.