Drop "xlink:" namespace for SVG 2.0

diagrams / diagrams-core

Core types and utilities

https://diagrams.github.io/

Other

93 stars 43 forks source link

Drop "xlink:" namespace for SVG 2.0 #91

Open kostmo opened 7 years ago

kostmo commented 7 years ago

The <a> element generated by the href function in diagrams-core contains a xlink:href attribute.

However, the xlink namespace has been deprecated since SVG 2.

byorgey commented 7 years ago

Hi @kostmo , thanks very much for the report! It seems you are right. However, I grepped through the diagrams-core source for xlink and didn't find anything. After a bit of digging it seems that this is actually coming from the svg-builder package. Would you mind re-filing this ticket against the svg-builder repo? Thanks!

(ping: @jeffreyrosenbluth )

jeffreyrosenbluth commented 7 years ago

It actually comes from diagrams-svg and was originally added in a PR, although I can't remember who submitted it. I'm also confused as to whether SVG is at 1.1 or 2.0, https://www.w3.org/standards/techs/svg#w3c_all. In any event I'll look into it.