search

diagrams / diagrams-gtk

Optional add-on to diagrams-cairo allowing diagrams to be rendered directly to GTK windows.
Other
4 stars 5 forks source link

gtk-0.13 compatibility #2

Closed nomeata closed 10 years ago

nomeata commented 10 years ago

Hi,

gtk-0.13 has been uploaded to hackage, and is dependet upon by other projects. Please consider uploading a compatible package to hackage.

Thanks, Joachim

JohnLato commented 10 years ago

The main change in gtk-0.13 is generalization of string arguments, so this should be quite simple. @byorgey , is there any problem if I fix it and push/upload myself? diagrams-gtk is the only package that would need a change, and probably just a version bump.

byorgey commented 10 years ago

Go for it! On Sep 8, 2014 7:19 PM, "John Lato" notifications@github.com wrote:

The main change in gtk-0.13 is generalization of string arguments, so this should be quite simple. @byorgey https://github.com/byorgey , is there any problem if I fix it and push/upload myself? diagrams-gtk is the only package that would need a change, and probably just a version bump.

— Reply to this email directly or view it on GitHub https://github.com/diagrams/diagrams-gtk/issues/2#issuecomment-54901911.

JohnLato commented 10 years ago

@byorgey as I thought, we just need to loosen the bounds. Usually I would only make this a minor version bump, but I'm tempted to make this diagrams-gtk-1.1.0.0 because it's a major bump in gtk2hs. Thoughts?

JohnLato commented 10 years ago

Ah, I'll go with 1.0.1.3 because that seems to be our precedent here.

byorgey commented 10 years ago

Yes, doing a major bump in diagrams-gtk would only cause unnecessary problems.

Note you can now just edit the bounds directly on Hackage, without making a new release. I've made you a maintainer of the package (which you should have been anyway). Though in that case you do have to remember to also edit the bounds in the git repo.

-Brnet

On Mon, Sep 8, 2014 at 8:27 PM, John Lato notifications@github.com wrote:

Ah, I'll go with 1.0.1.3 because that seems to be our precedent here.

— Reply to this email directly or view it on GitHub https://github.com/diagrams/diagrams-gtk/issues/2#issuecomment-54907713.

JohnLato commented 10 years ago

Uploaded diagrams-gtk 1.0.1.3, so I'm closing this issue. @nomeata please re-open if it doesn't work for you.

(I was and remain strongly against editing the bounds directly on hackage FWIW)

bergey commented 10 years ago

Incidentally, while editing .cabal files on Hackage is the only way to retroactively tighten bounds, and I'm very glad to have the feature for that purpose, it makes life more difficult for distribution packagers. It also makes a coherent Changelog challenging. For that reason, I prefer to keep using the point version bumps, though I did edit a .cabal file the other day when I found an error immediately after upload.